Mike,

Thanks for responding.
Yes indeed--the python client definitely needs work.  The changes you
have below sound quite good; I'm interested in reviewing your patch.
If you would like to contribute the client to the Solr project, you
will need to open an issue here:

http://issues.apache.org/jira/browse/SOLR

I will do that.

That takes care of the licensing issues and keeps better track of the
feedback you receive.  I took a quite glance, and a few things popped
out:
 - why not use the python response format?
I'm using the python response format for several one-off scripts (it's quite handy!), but I wouldn't want to put such a thing in production. There's too many security implications of blindly eval'ing code being delivered from a server. Especially in a general-purpose library.
 - you can convert to/from solr date/time to a python one in a oneliner:
           datetime.datetime.strptime(value, "%Y-%m-%dT%H:%M:%SZ")
I was trying to support Python versions < 2.5, as not all major distributions are delivering 2.5 yet. I could change to require Python 2.5 if that's preferred, however.

-- Jason


Reply via email to