: I included the jar in lib, but exclude it from distribution, is this ok?
excluding it from the war isn't the same as excluding it from distribution
(it looks like it would still be included in both the source and binary
tgz/zip releases).
assuming this is what you mean by easymock...
http://www.easymock.org/
http://www.easymock.org/License.html
...then before any real questions about wether or not it's useful and do
we want to use it can be answered we have to figure out wether we re
allowed to use it -- it's the MIT License, which seems to (currently)
be acceptible for 3rd party libraries included in apache releases...
http://people.apache.org/~cliffs/3party.html
... but it would definitely needs to be mentioned in the NOTICE.txt
As for the "do we want it" questions, i'm not really familiar with
easymock or jMock, so i don't have an opinion ... and i don't really have
the energy to investigate further at the moment. (this cold is kicking my
ass, and checking mail in fits and spurts is both helping keep me sane,
and making my sinus headache worse ... so i'm dmned if i do damned if i
don't)
For the record, i think adding a new 3rd party jar is a weighty enough
change that it should have warranted opening a Jirra issue and asking for
comments prior to commiting. I also think that the bug which motivatied
this test probably should have been filed in jira, so that if anyone else
ever asked about it, we would have refrence URL to cite when discussing
the bug, the fix, and any potential complications (or future bugs) that
may arrise from it.
-Hoss
