i'll have another go at the patch tomorrow morning; testing the raw-schema.jsp (even if it's not used) and put back the test. - will
________________________________ From: Chris Hostetter [mailto:[EMAIL PROTECTED] Sent: Thu 5/24/2007 6:02 PM To: solr-dev@lucene.apache.org Subject: RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file : 2) why did you remove testDynamicCopy() from IndexSchemaTest ? : : becuase it had nothing to do with testing the index schema. as far as i : could tell it was a ctrl-c / ctrl-v error. that or i'm really blind and : happy to put it back. idon't see a test with that name defined anywhere. it's testing that you can declare dynamic fields and copy them using copyField ... that sounds like an IndexSchemaTest to me (lots of other schema related tests may be in BasicFunctionalityTest or ConvertedLegacyTest, but we should try to use the class specific test classes when the test is very narrow) : 3) raw-schema.jsp on the trunk appears to be completely broken (multiple : <%@ page contentType="..."%> declarations), and not linked to from the : my patch worked but i also saw that it wasn't linked anywhere. i thought your patch left the multiple contentType declarations, but i don't rememebr for certain now ... it's a trivial issue either way. -Hoss
