[ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-143: ------------------------------- Attachment: SOLR-143-CloverAndPMD.patch Updated to apply with trunk -- unlike the original patch, this does not try to fix the serious errors (we can do that later) For anyone trying to run - this does not require that you have PMD or clover, it just generates reports if you ask for them (and have it configured) For anyone trying to run, these are the command lines: ant clean ant test -Drun.clover=true ant clover-reports -Drun.clover=true ant pmd-reports Is there a reason to have the -Drun.clover configuration rather then the target specifying if clover is used or not? > Support for PMD and Clover > -------------------------- > > Key: SOLR-143 > URL: https://issues.apache.org/jira/browse/SOLR-143 > Project: Solr > Issue Type: Improvement > Reporter: Hoss Man > Priority: Minor > Attachments: pmd-and-clover.diff, SOLR-143-CloverAndPMD.patch > > > had some time on a plane this weekend, so I adapted some of the clover hooks > from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a > bug pattern finding tool). > the PMD hook actually teste the PMD ruleset twice, once warning about any > violations, and once failing the build if any serious violations were found > ... the goal would be to hook this into the "ant test" target so you can't > successfully build if you have any serious rule violations. > i strarted with a custom ruleset based on some of the bigger rules from PMD > ... the theory being that as well clean up the code base we can add more > nit-picky rules if we want to :) > User is required to provide their own copy of PMD and/or clover on in an > ANT_LIB. Clover requires (ASF committer) license, PMD is freely available... > http://pmd.sourceforge.net/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.