[ 
https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan McKinley updated SOLR-133:
-------------------------------

    Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch

Extracts the request parsing and update handling into two parts.

This adds an "UpdateRequestProcessor" that handles the actual updating.  This 
offers a good place for authentication / document transformation etc.  This can 
all be reuse if we have a JSONUpdate handler.  The UpdateRequestProcessor can 
be changed using an init param in solrconfig,xml:

  <requestHandler name="/update" class="solr.XmlUpdateRequestHandler" >
    <str 
name="update.processor.class">org.apache.solr.handler.UpdateRequestProcessor</str>
  </requestHandler>

Moved the XPP version to XppUpdateRequestHandler and mapped it to:
  <requestHandler name="/update/xpp" class="solr.XppUpdateRequestHandler" />

My initial (not accurate) tests don't show any significant time difference 
between the two -- we should keep both in the code until we are confident the 
new one is stable.

- - - - -

Thorsten - can you check if the STAX includes are all in good shape?  Is it ok 
to use:
 import javanet.staxutils.BaseXMLInputFactory;



> change XmlUpdateRequestHandler to use StAX instead of XPP
> ---------------------------------------------------------
>
>                 Key: SOLR-133
>                 URL: https://issues.apache.org/jira/browse/SOLR-133
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, 
> SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, 
> SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, 
> SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, 
> SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, 
> SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, 
> SOLR-133-XmlUpdateRequestHandler-StAX-139.patch, SOLR-133.diff, SOLR-133.diff
>
>
> there has been discussion of using StAX for XML parsing of updates instead of 
> XPP ... opening an issue to track it as a possible improvement  (orriginally 
> mentioned in SOLR-61, but that task was more specificly about refactoring the 
> existing code)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to