[ 
https://issues.apache.org/jira/browse/SOLR-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508890
 ] 

Yonik Seeley commented on SOLR-272:
-----------------------------------

> To be honest, I'm not sure the complexity of dealing with a 
> Map<String,Object> (where the Object may be a 
> collection or not) is worth the marginal speedup.

I'm not sure either, but one reason the speedup is marginal is that it's not 
the bottleneck (other things are taking more time, like dynamic copy-field 
checking... I've never checked that code to see if it could be optimized, but 
things are quite a bit faster when all the dynamic fields are removed).

SolrInputDocument could similary be sped up by getting rid of the Map for 
boosts.
One could either store a bare value, or a BoostedValue.

class BoostedValue {
  float boost;
  Object value;
}



> SolrDocument performance testing
> --------------------------------
>
>                 Key: SOLR-272
>                 URL: https://issues.apache.org/jira/browse/SOLR-272
>             Project: Solr
>          Issue Type: Test
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>         Attachments: SOLR-272-SolrDocumentPerformanceTesting.patch, 
> SOLR-272-SolrDocumentPerformanceTesting.patch, 
> SolrDocumentPerformanceTester.java, SolrDocumentPerformanceTester.java, 
> SolrInputDoc.patch, SolrInputDoc.patch
>
>
> In 1.3, we added SolrInputDocument -- a temporary class to hold document 
> information.  There is concern that this may be less then ideal 
> performance-wise.
> To settle some concerns (mine included) I want to compare a few SolrDocument 
> implementations to make sure we are not doing something crazy.
> I implemented a LuceneInputDocument subclass of SolrInputDocument that stores 
> its values directly in Lucene Document (rather then a Map<String,Collection>).
> This is a quick test comparing:
> 1. Building documents with SolrInputDocument 
> 2. Building documents with LuceneInputDocument (same interface writing 
> directly to Document)
> 3. using DocumentBuilder (solr 1.2, solr 1.1)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to