[
https://issues.apache.org/jira/browse/SOLR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509709
]
Mike Klaas commented on SOLR-225:
---------------------------------
Looking great Ryan (again, only commenting on the Highlighting configurability
parts)
should:
protected boolean emptyArray(String[] arr) {
return (arr == null || arr.length == 0 || arr[0] == null ||
arr[0].trim().length() == 0);
}
perhaps be defined as
protected boolean emptyArray(String[] arr) {
return (arr == null || arr.length == 0 || arr.length == 1arr[0] == null ||
arr[0].trim().length() == 0);
}
> Allow pluggable Highlighting classes -- Formatters and Fragmenters
> ------------------------------------------------------------------
>
> Key: SOLR-225
> URL: https://issues.apache.org/jira/browse/SOLR-225
> Project: Solr
> Issue Type: Improvement
> Reporter: Brian Whitman
> Assignee: Ryan McKinley
> Attachments: SOLR-225+260-HighlightPlugins.patch,
> SOLR-225+260-HighlightPlugins.patch, SOLR-225-HighlightingConfig.patch,
> SOLR-225-HighlightingConfig.patch, SOLR-225-HighlightingConfig.patch,
> SOLR-225-HighlightingConfig.patch, SOLR-225-HighlightingConfig.patch
>
>
> Highlighting should support a pluggable architecture similar to what is seen
> with RequestHandlers, Fields, FieldTypes, etc
> '
> For more background:
> http://www.nabble.com/Custom-fragmenter-tf3681588.html#a10289335
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
