[
https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515208
]
Pieter Berkel commented on SOLR-258:
------------------------------------
Looking good Hoss, the NOW issue seems to be resolved and the results look
consistent after a quick test.
> * what should happen if "end < start" or "gap < 0" ... maybe those should be
> okay as long as both are true.
It is probably wise to explicitly check for ("end < start" XOR "gap < 0") and
return an error if so, otherwise the request gets caught in an infinite loop.
Just on the subject of errors, I notice that exceptions thrown by the date
facet code are caught in SimpleFacets.getFacetCounts() and written out in the
response:
try {
res.add("facet_queries", getFacetQueryCounts());
res.add("facet_fields", getFacetFieldCounts());
res.add("facet_dates", getFacetDateCounts());
} catch (Exception e) {
SolrException.logOnce(SolrCore.log, "Exception during facet counts", e);
res.add("exception", SolrException.toStr(e));
}
This doesn't seem very consistent the way other handlers deal with exceptions
(i.e. http response code > 400), is there any reason why it is done this way in
SimpleFacets?
I also think it would also be a good idea to merge "facet_dates" response field
into "facet_fields" so that all the facet data in the response is stored in the
one location, how feasible would it be to do this?
> Date based Facets
> -----------------
>
> Key: SOLR-258
> URL: https://issues.apache.org/jira/browse/SOLR-258
> Project: Solr
> Issue Type: New Feature
> Reporter: Hoss Man
> Assignee: Hoss Man
> Attachments: date_facets.patch, date_facets.patch, date_facets.patch,
> date_facets.patch, date_facets.patch, date_facets.patch, date_facets.patch
>
>
> 1) Allow clients to express concepts like...
> * "give me facet counts per day for every day this month."
> * "give me facet counts per hour for every hour of today."
> * "give me facet counts per hour for every hour of a specific day."
> * "give me facet counts per hour for every hour of a specific day and
> give me facet counts for the
> number of matches before that day, or after that day."
> 2) Return all data in a way that makes it easy to use to build filter queries
> on those date ranges.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
