[ 
https://issues.apache.org/jira/browse/SOLR-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519278
 ] 

Hoss Man commented on SOLR-332:
-------------------------------

It's been a while since I looked closely at FieldType, but i seem to remember a 
similar discussion coming up regarding the properties and isTokenized.

If people want to put logic like this in custom FieldTypes i think it makes 
more sense to add accessors (ala: isStored()) that can be used to check the 
prop values (or be overridden completely by subclasses to ignore the property 
outright) then it would to expose the properties directly.

I agree trueProperties and falseProperties aren't curently safe to use in 
subclasses -- i think the right way to fix that is to take away their protected 
status and make them private.

> Visibility of static int fields in FieldProperties should be increased to 
> allow custom FieldTypes to use them
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-332
>                 URL: https://issues.apache.org/jira/browse/SOLR-332
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Jonathan Woods
>            Priority: Minor
>
> Constants in org.apache.solr.schema aren't visible to classes outside that 
> package, yet they're useful e.g. for custom FieldTypes.  Could their 
> visibility be increased?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to