[
https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520691
]
Hoss Man commented on SOLR-267:
-------------------------------
format looks fine to me, some minor nits from a quick skim of the patch...
1) "protected NamedList toLog" should have some javadocs.
2) "public NamedList getResponseHeader()" seems to have incorrect javadocs
3) I'm pretty sure the use HttpServletResponse.addHeader in SolrDispatchFilter
requires that the header names not contains spaces ... that's not something
currently guaranteed by solrRsp.getResponseHeader()
4) although the odds of the ClassCastException in SolrDispatchFilter
asymptotically approach zero, it should still be logged properly instead of
using cce.printStackTrace()
> log handler + query + hits
> --------------------------
>
> Key: SOLR-267
> URL: https://issues.apache.org/jira/browse/SOLR-267
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.3
> Reporter: Will Johnson
> Priority: Minor
> Fix For: 1.3
>
> Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch,
> LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch,
> LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
