: > 1) getSolrCore() should also synchronize on SolrCore.class : : This is the big thing I wanted to avoid.
why? that's the way the old impl worked right? : I tried this originally, but it breaks all the tests -- the tests require the : last constructed core is returned form getSolrCore() that seems a little scary ... which tests? tests of code that assume a multi core enviornment should never be using getSolrCore() ... legacy tests shouldn't care which core they get, as long as it's always the same. : The only quick fix is #1 -- should we do that now or wait till SOLR-350? : I'm inclined to wait and keep an eye on SOLR-350. i'm always a fan of quick fixes ... even if they are only temporary ... but like i said, i'm confused as to why you wanted to avoid #1 or why #2 would breakthings. In general: if you've got your eye on this as part of SOLR-350 then i'm not that worried. carry on good sir, carry on. -Hoss
