[ https://issues.apache.org/jira/browse/SOLR-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554519 ]
Yonik Seeley commented on SOLR-303: ----------------------------------- {quote}}We should extract out a few simple things and commit them quickly to make this go more smoothly: 1. move SearchHandler to o.a.s.handler.component - I vote you go ahead and commit that change. 2. Create a separate issue for adding SolrDocument to XMLWriter 3. Move solrj into the main source tree. I'm not sure the best way to do this, but I don't think solrj should sit in its own source folder if the core depends on it. {quote} Definitely agree on #1 and #2. For #3, are there SolrJ parts (or future parts) that we wouldn't want automatically bundled with Solr? {quote}Is there a good reason to use the same handler for distributed search?{quote} It seems like a single search component should be able to handle distributed search. If that's the case, what separates a handler that is distributed and one that isn't? The first thing that occured to me was to just detect the presence of shards[] after the prepare phase. There is a side benefit in that a component can control whether a request is distributed or not (all solrconfig could be the same for systems in a cluster, with some sort of external system controlling topology). One could have a distributed handler that could delegate or handle non-distributed requests, but it seems to amount to the same thing (a single handler that can do both on the fly). Saving an if() doesn't seem too compelling (the current code could certainly be refactored to be cleaner anyway). Are there other benefits to having a separate DistributedSearchHandler though? . > Distributed Search over HTTP > ---------------------------- > > Key: SOLR-303 > URL: https://issues.apache.org/jira/browse/SOLR-303 > Project: Solr > Issue Type: New Feature > Components: search > Reporter: Sharad Agarwal > Assignee: Yonik Seeley > Attachments: distributed.patch, distributed.patch, fedsearch.patch, > fedsearch.patch, fedsearch.patch, fedsearch.patch, fedsearch.patch, > fedsearch.patch, fedsearch.patch, fedsearch.stu.patch, fedsearch.stu.patch > > > Searching over multiple shards and aggregating results. > Motivated by http://wiki.apache.org/solr/DistributedSearch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.