[ 
https://issues.apache.org/jira/browse/SOLR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571403#action_12571403
 ] 

mightymax edited comment on SOLR-341 at 2/22/08 6:53 AM:
-------------------------------------------------------------

it would be nice to have support for custom instances of 
StandardRequestHandler. Apache_Solr_Service now uses a class constant 
SEARCH_SERVLET to build it's query.

A quick fix would be:
add extra parameter to function search:
public function search($query, $offset = 0, $limit = 10, $params = array(), 
$search_servlet = null)

and change last line of this function to:
$searchUrl = $search_servlet==null ? $this->_searchUrl : 
$this->_constructUrl($search_servlet);
return $this->_sendRawGet($searchUrl . $this->_queryDelimiter . $queryString);

Another wish:
please make your methods and object variables "protected" in stead of "private" 
so we can extend your great Class.

      was (Author: mightymax):
    it would be nice to have support for custom instances of 
StandardRequestHandler. Apache_Solr_Service now uses a class constant 
SEARCH_SERVLET to build it's query.

A quick fix would be:
add extra parameter to function search:
public function search($query, $offset = 0, $limit = 10, $params = array(), 
$search_servlet = null)

and change last line of this function to:
$searchUrl = $search_servlet==null ? $this->_searchUrl : 
$this->_constructUrl($search_servlet);
return $this->_sendRawGet($searchUrl . $this->_queryDelimiter . $queryString);

Another wish:
please make your methods "protected" in stead of "private" so we can extend 
your great Class.
  
> PHP Solr Client
> ---------------
>
>                 Key: SOLR-341
>                 URL: https://issues.apache.org/jira/browse/SOLR-341
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - php
>    Affects Versions: 1.2
>         Environment: PHP >= 5.2.0 (or older with JSON PECL extension or other 
> json_decode function implementation). Solr >= 1.2
>            Reporter: Donovan Jimenez
>            Priority: Trivial
>         Attachments: SolrPhpClient.zip
>
>
> Developed this client when the example PHP source didn't meet our needs.  The 
> company I work for agreed to release it under the terms of the Apache License.
> This version is slightly different from what I originally linked to on the 
> dev mailing list.  I've incorporated feedback from Yonik and "hossman" to 
> simplify the client and only accept one response format (JSON currently).
> When Solr 1.3 is released the client can be updated to use the PHP or 
> Serialized PHP response writer.
> example usage from my original mailing list post:
> <?php
> require_once('Solr/Service.php');
> $start = microtime(true);
> $solr = new Solr_Service(); //Or explicitly new Solr_Service('localhost', 
> 8180, '/solr');
> try
> {
>         $response = $solr->search('solr', 0, 10,
>                 array(/* you can include other parameters here */));
>         echo 'search returned with status = ', 
> $response->responseHeader->status,
>                 ' and took ', microtime(true) - $start, ' seconds', "\n";
>         //here's how you would access results
>         //Notice that I've mapped the values by name into a tree of stdClass 
> objects
>         //and arrays (actually, most of this is done by json_decode )
>         if ($response->response->numFound > 0)
>         {
>                 $doc_number = $response->response->start;
>                 foreach ($response->response->docs as $doc)
>                 {
>                         $doc_number++;
>                         echo $doc_number, ': ', $doc->text, "\n";
>                 }
>         }
>         //for the purposes of seeing the available structure of the response
>         //NOTE: Solr_Response::_parsedData is lazy loaded, so a print_r on 
> the response before
>         //any values are accessed may result in different behavior (in case
>         //anyone has some troubles debugging)
>         //print_r($response);
> }
> catch (Exception $e)
> {
>         echo $e->getMessage(), "\n";
> }
> ?>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to