[ 
https://issues.apache.org/jira/browse/SOLR-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573314#action_12573314
 ] 

Grant Ingersoll commented on SOLR-386:
--------------------------------------

{quote}
Made SolrHighlighter an interface
{quote}

Why not just extend and override?  The general problem w/ interfaces is it gets 
hard to maintain back-compatibility in this kind of environment.  Another 
option would be to abstract SolrHighlighter to extend AbstractSolrHighlighter 
and then your new highlighter could just extend AbstractSolrHightlighter

> Add confuguration to specify SolrHighlighter implementation
> -----------------------------------------------------------
>
>                 Key: SOLR-386
>                 URL: https://issues.apache.org/jira/browse/SOLR-386
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>    Affects Versions: 1.3
>            Reporter: Eli Levine
>            Assignee: Mike Klaas
>         Attachments: SOLR-386-SolrHighlighter.patch, 
> SOLR-386-SolrHighlighter.patch, SOLR-386-SolrHighlighter.patch, 
> SOLR-386-SolrHighlighter.patch
>
>
> It would be great if SolrCore allowed the highlighter class to be 
> configurable.  A good way would be to add a +class+ attribute to the 
> <highlighting> element in solrconfig.xml, similar to how the RequestHandler 
> instance is initialized in SorCore.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to