[
https://issues.apache.org/jira/browse/SOLR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588900#action_12588900
]
Noble Paul commented on SOLR-486:
---------------------------------
The changes look good , infact very good. it is highly optimized.
You already incorporated the Document changes which i added
The writeUTF bug was a very critical one which I noticed after cutting the
patch.Anyway you fixed it.
I guess one test is failing in TestDistributedSearch
unit.framework.AssertionFailedError: .response.maxScore:4321.0!=null
at
org.apache.solr.TestDistributedSearch.compareResponses(TestDistributedSearch.java:416)
.....
need to take a look
I vote vote for preserving SimpleOrderedMap.(anyway there is are two reserved
types one can be taken up)
Makee sense to use this in SolrJ . But there are people using SolrJ with
Solr1.2 and older versions of Solr1.3 in production. We must take care of that
in the code.
send wt=javabin
read the response header, if the content type is application/octet-steram use
BinaryResponseParser or use XMLResponseparser
> Support binary formats for QueryresponseWriter
> ----------------------------------------------
>
> Key: SOLR-486
> URL: https://issues.apache.org/jira/browse/SOLR-486
> Project: Solr
> Issue Type: Improvement
> Components: clients - java, search
> Reporter: Noble Paul
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-486.patch, SOLR-486.patch, SOLR-486.patch,
> SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch
>
>
> QueryResponse writer only allows text data to be written.
> So it is not possible to implement a binary protocol . Create another
> interface which has a method
> write(OutputStream os, SolrQueryRequest request, SolrQueryResponse response)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
