OK, Clover should be hooked in and hopefully doesn't have to go
through many hoops. You can see reports on the latest at: http://hudson.zones.apache.org/hudson/job/Solr-trunk/clover/
Too bad we didn't put in a Google Summer of Code option to write test
cases like the Derby folks did. :-)
I think we may want to consider, similarly to what we do in Lucene-
Java, is introducing a code freeze before official release, and one of
the things we do is tackle the fact that a pretty sizable chunk of
Solr code is not ever tested. Typically, in Lucene land we freeze for
7 to 10 days and the only allowed commits in that time are blockers
and documentation. We probably could add to that test cases.
I also find the BasicFunctionalityTest to be a bit annoying from a
purist Unit Testing standpoint. For instance, today I was looking at
the Date Faceting patch as applied to SimpleFacets and instinctively
went to look for TestSimpleFacets (or, SimpleFacetsTest) which doesn't
exist. Then, later, discovered that the Faceting test stuff is in the
BFT class, which is a bit harder to remember and I think causes people
to wonder where tests are located for a given class.
Anyway, just my two cents on how we can improve testing in Solr.
-Grant
On Apr 16, 2008, at 12:21 PM, Chris Hostetter wrote:
: I'm testing adding clover to hudson builds, so please disregard
any failure
: notices.
Oh yeah ... i've been meaning to get to that.
FWIW: I'm not sure how far you've gotten, but i don't think we need to
jump through as many hoops as Lucene does to build with clover, then
build
again without -- we don't advertise the artifacts from Hudson
because we
also still have nightly.sh. Having both is a nice little bit of
sanity
check, and I think it would be fine to make the hudson build have no
artifacts, just verify the tests and run the metrics.
-Hoss
