[
https://issues.apache.org/jira/browse/SOLR-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597680#action_12597680
]
Otis Gospodnetic commented on SOLR-553:
---------------------------------------
I think there are no pure vs. mixed situation any more. If usePH=true we use
SpanScorer otherwise we use QueryScorer, or at least that's how I read the
patch.
{code:DefaultSolrHighlighter.java:295-304|borderStyle=solid}
if
(Boolean.valueOf(req.getParams().get(HighlightParams.USE_PHRASE_HIGHLIGHTER))) {
// wrap CachingTokenFilter around TokenStream for reuse
tstream = new CachingTokenFilter(tstream);
// get highlighter
highlighter = getPhraseHighlighter(query, fieldName, req,
(CachingTokenFilter) tstream);
// after highlighter initialization, reset tstream since
construction of highlighter already used it
tstream.reset();
}
else {
// use "the old way"
highlighter = getHighlighter(query, fieldName, req);
}
{code}
> Highlighter does not match phrase queries correctly
> ---------------------------------------------------
>
> Key: SOLR-553
> URL: https://issues.apache.org/jira/browse/SOLR-553
> Project: Solr
> Issue Type: New Feature
> Components: highlighter
> Affects Versions: 1.2
> Environment: all
> Reporter: Brian Whitman
> Assignee: Otis Gospodnetic
> Attachments: highlighttest.xml, Solr-553.patch, Solr-553.patch,
> Solr-553.patch
>
>
> http://www.nabble.com/highlighting-pt2%3A-returning-tokens-out-of-order-from-PhraseQuery-to16156718.html
> Say we search for the band "I Love You But I've Chosen Darkness"
> .../selectrows=100&q=%22I%20Love%20You%20But%20I\'ve%20Chosen%20Darkness%22&fq=type:html&hl=true&hl.fl=content&hl.fragsize=500&hl.snippets=5&hl.simple.pre=%3Cspan%3E&hl.simple.post=%3C/span%3E
> The highlight returns a snippet that does have the name altogether:
> Lights (Live) : <span>I</span> <span>Love</span> <span>You</span> But
> <span>I've</span> <span>Chosen</span> <span>Darkness</span> :
> But also returns unrelated snips from the same page:
> Black Francis Shop "<span>I</span> Think <span>I</span> <span>Love</span>
> <span>You</span>"
> A correct highlighter should not return snippets that do not match the phrase
> exactly.
> LUCENE-794 (not yet committed, but seems to be ready) fixes up the problem
> from the Lucene end. Solr should get it too.
> Related: SOLR-575
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
