[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598951#action_12598951 ]
Thomas Peuss commented on SOLR-505: ----------------------------------- I don't think that is a good idea to include the patch for SOLR-505 with the patch for SOLR-502. Sean included it only because he depends on the code changes we do with SOLR-505. I would like to see the following: * Rework SOLR-505 like Otis mentioned. As we only change the "naming" and not the overall approach I am fine with that. I can do that tomorrow. * Commit SOLR-505 * Rework SOLR-502 to use the changed API and to be compatible with trunk * Commit SOLR-505 SOLR-505 and SOLR-502 have different goals. So combining them makes no big sense to me and might confuse people. > Give RequestHandlers the possiblity to suppress the generation of HTTP > caching headers > -------------------------------------------------------------------------------------- > > Key: SOLR-505 > URL: https://issues.apache.org/jira/browse/SOLR-505 > Project: Solr > Issue Type: Bug > Components: search > Affects Versions: 1.3 > Reporter: Thomas Peuss > Assignee: Otis Gospodnetic > Fix For: 1.3 > > Attachments: SOLR-505.patch, SOLR-505.patch > > > The code from SOLR-127 emits HTTP cache headers for all handlers if > configured. We should not emit cache related headers for update request > handlers. Partial responses (coming from the Timeout request stuff) should > not be cached as well. > To solve this problem we can simply add two methods to the SolrQueryResponse > class (like void setAvoidHTTPCaching(boolean) and boolean > isAvoidHTTPCaching() - the default for the value would be false). The update > request handlers should set this to true all the time. The partial response > stuff can set this to true as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.