[
https://issues.apache.org/jira/browse/SOLR-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599412#action_12599412
]
Shalin Shekhar Mangar commented on SOLR-572:
--------------------------------------------
Grant -- No, it is not thread-safe. Actually I wanted to put this
initialization code in a inform method to avoid this situation. Since that did
not work, I moved this into prepare method only as a stop gap arrangement. See
http://www.nabble.com/Accessing-IndexReader-during-core-initialization-hangs-init-to17259235.html
for details.
I'd suggest doing the following:
* Move the initial dictionary creation into a inform method if someone with
more knowledge about the SolrCore class can fix the issue I described in my
mail.
* The code in prepare can be used to reload dictionaries by specifying a
request parameter (say spellcheck.rebuild=true)
* Since we're already using a ConcurrentHashMap, the above two things should
take care of all thread-safety issues.
> Spell Checker as a Search Component
> -----------------------------------
>
> Key: SOLR-572
> URL: https://issues.apache.org/jira/browse/SOLR-572
> Project: Solr
> Issue Type: New Feature
> Components: spellchecker
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-572.patch, SOLR-572.patch, SOLR-572.patch,
> SOLR-572.patch, SOLR-572.patch
>
>
> Expose the Lucene contrib SpellChecker as a Search Component. Provide the
> following features:
> * Allow creating a spell index on a given field and make it possible to have
> multiple spell indices -- one for each field
> * Give suggestions on a per-field basis
> * Given a multi-word query, give only one consistent suggestion
> * Process the query with the same analyzer specified for the source field and
> process each token separately
> * Allow the user to specify minimum length for a token (optional)
> Consistency criteria for a multi-word query can consist of the following:
> * Preserve the correct words in the original query as it is
> * Never give duplicate words in a suggestion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.