[
https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599523#action_12599523
]
Otis Gospodnetic commented on SOLR-502:
---------------------------------------
* Does timeallowed=-1 mean "do not time out at all"? Is that mentioned
anywhere? I also see a check for timeallowed > 0, so 0 also seems to mean "do
not time out at all".
* CamelCase: timeallowed => timeAllowed?
* I see "This should only be called using either filterList or filter, but not
both.", but I don't see a check for that. Should there be a test for the two
vars?
* I see System.out.println( "partialResults0: " + partialResults );
The rest, from what I can tell, looks good.
P.S.
SOLR-502-solrj.patch is just an old patch that we can really remove so it
doesn't confuse anyone, correct?
> Add search time out support
> ---------------------------
>
> Key: SOLR-502
> URL: https://issues.apache.org/jira/browse/SOLR-502
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Sean Timm
> Assignee: Otis Gospodnetic
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-502-solrj.patch, SOLR-502.patch, solrTimeout.patch,
> solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch
>
>
> Uses LUCENE-997 to add time out support to Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
