I'm +1 on getting the basic stuff done and committed for 1.3. If Grant is hot on getting the abstractions in for 1.3, he will do so, but I think it's OK to get this done in 2 parts: 1) core working and committed for 1.3 2) abstractions working and committed after 1.3 if Grant doesn't finish them before 1.3
Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch ----- Original Message ---- > From: Shalin Shekhar Mangar <[EMAIL PROTECTED]> > To: solr-dev@lucene.apache.org > Sent: Tuesday, June 3, 2008 3:53:10 PM > Subject: Re: [jira] Commented: (SOLR-572) Spell Checker as a Search Component > > The current patch has been broken for some days now and implementing a > correct query parsing logic may take time to get right. Let's not aim for > everything to get into the 1.3 release. > > I would like to cut down the scope of this issue to a implementation that > indexes files and Lucene indices (both Solr and arbitary) and gives > suggestions while using the correct analyzer for multi-word queries. Let's > get a spell checker working and commit it. We can deal with more > enhancements like abstractions for custom spellcheckers and query parsing > etc. in another issue which can be dealt with separately (in 1.3 or after). > Thoughts? If there is a general consensus, I can give a new patch which can > be good enough to go in. > > On Sat, May 31, 2008 at 2:44 AM, Oleg Gnatovskiy (JIRA) > wrote: > > > > > [ > > > https://issues.apache.org/jira/browse/SOLR-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601256#action_12601256] > > > > Oleg Gnatovskiy commented on SOLR-572: > > -------------------------------------- > > > > I installed the latest patch. Still getting a NPE. Here is my config: > > > > > > class="org.apache.solr.handler.component.SpellCheckComponent"> > > > > > > false > > > > false > > > > 1 > > > > > > > > > > name="classname">org.apache.solr.spelling.FileBasedSpellChecker > > external > > spellings.txt > > UTF-8 > > text_ws > > > > name="indexDir">/usr/local/apache/lucene/solr2home/solr/data/spellIndex > > > > > > > > > > Here is the URL I am hitting: > > > http://localhost:8983/solr/select/?q=pizza&spellcheck=true&spellcheck.dictionary=external&spellcheck.build=true > > > > Here is the error: > > > > HTTP Status 500 - null java.lang.NullPointerException at > > org.apache.lucene.index.Term.(Term.java:39) at > > org.apache.lucene.index.Term.(Term.java:36) at > > > org.apache.lucene.search.spell.SpellChecker.suggestSimilar(SpellChecker.java:228) > > at > > > org.apache.solr.spelling.AbstractLuceneSpellChecker.getSuggestions(AbstractLuceneSpellChecker.java:71) > > at > > > org.apache.solr.handler.component.SpellCheckComponent.process(SpellCheckComponent.java:177) > > at > > > org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:153) > > at > > > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:125) > > at org.apache.solr.core.SolrCore.execute(SolrCore.java:965) at > > > org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:339) > > at > > > org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:274) > > at > > > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > > at > > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > > at > > > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) > > at > > > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > > at > > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > > at > > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) > > at > > > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > > at > > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286) > > at > > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) > > at > > > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) > > at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447) > > at java.lang.Thread.run(Thread.java:619) > > > > spelling.txt is in my solr/home/conf. > > > > > Spell Checker as a Search Component > > > ----------------------------------- > > > > > > Key: SOLR-572 > > > URL: https://issues.apache.org/jira/browse/SOLR-572 > > > Project: Solr > > > Issue Type: New Feature > > > Components: spellchecker > > > Affects Versions: 1.3 > > > Reporter: Shalin Shekhar Mangar > > > Assignee: Grant Ingersoll > > > Priority: Minor > > > Fix For: 1.3 > > > > > > Attachments: SOLR-572.patch, SOLR-572.patch, SOLR-572.patch, > > SOLR-572.patch, SOLR-572.patch, SOLR-572.patch, SOLR-572.patch, > > SOLR-572.patch, SOLR-572.patch, SOLR-572.patch, SOLR-572.patch, > > SOLR-572.patch, SOLR-572.patch, SOLR-572.patch, SOLR-572.patch > > > > > > > > > Expose the Lucene contrib SpellChecker as a Search Component. Provide the > > following features: > > > * Allow creating a spell index on a given field and make it possible to > > have multiple spell indices -- one for each field > > > * Give suggestions on a per-field basis > > > * Given a multi-word query, give only one consistent suggestion > > > * Process the query with the same analyzer specified for the source field > > and process each token separately > > > * Allow the user to specify minimum length for a token (optional) > > > Consistency criteria for a multi-word query can consist of the following: > > > * Preserve the correct words in the original query as it is > > > * Never give duplicate words in a suggestion > > > > -- > > This message is automatically generated by JIRA. > > - > > You can reply to this email to add a comment to the issue online. > > > > > > > -- > Regards, > Shalin Shekhar Mangar.
