[ 
https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605719#action_12605719
 ] 

Yonik Seeley commented on SOLR-502:
-----------------------------------

bq. Do you have a suggestion on how to get it into the response header? That 
isn't available down at the SolrIndexSearcher level as far as I can tell.

Off the top of my head, it seems like it might be cleaner to throw an exception 
in the SolrIndexSearcher method doing the searching (that would have the added 
benefit of  automatically bypassing DocSet/DocList caching, etc).

Catch that exception in the query component and set a flag in the header 
indicating that a timeout happened.

Or if it's easier, pass more info down to the SolrIndexSearcher.

After all, this only handles timeouts at the query level (not query 
expansion/rewriting, highlighting, retrieving stored fields, faceting, or any 
other number of components that will be added in the future).  It also doesn't 
even totally handle timeouts at the query level... one could construct a query 
that takes a lot of time yet matches no documents so there is never an 
opportunity to time out.  Then there is the issue of false positives (a major 
GC compaction hits and causes all the currently running queries to time out).  
Given these restrictions, and the fact that most people would choose not to get 
partial results, it seems like we should really try to limit the 
impact/invasiveness of this feature.


> Add search time out support
> ---------------------------
>
>                 Key: SOLR-502
>                 URL: https://issues.apache.org/jira/browse/SOLR-502
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Sean Timm
>            Assignee: Otis Gospodnetic
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, 
> SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, 
> solrTimeout.patch, solrTimeout.patch
>
>
> Uses LUCENE-997 to add time out support to Solr.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to