[ 
https://issues.apache.org/jira/browse/SOLR-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617016#action_12617016
 ] 

ryantxu edited comment on SOLR-660 at 7/25/08 5:32 PM:
-------------------------------------------------------------

patch that removes the no-op factory and forces eveything to be a chain.  Now 
the configuration looks like this:
{code:xml}
<updateRequestProcessorChain name="name" default="true">
  <processor class="solr.CustomUpdateRequestProcessorFactory" >
   <lst name="name">
     <str name="n1">x1</str>
     <str name="n2">x2</str>
   </lst>
  </processor>
  <processor class="solr.RunUpdateProcessorFactory" />
  <processor class="solr.LogUpdateProcessorFactory" />
</updateRequestProcessorChain>
{code}

The big changes are:
 * processor factories are now loaded with NamedListInitalizedPluginLoader -- 
it is no longer custon Node parsing.  
 * the Factories no longer have direct access to core.  if they need it, they 
can implement SorlCoreAware
 * moves all config parsing out of the processor classes.  



      was (Author: ryantxu):
    patch that removes the no-op factory and forces eveything to be a chain.  
Now the configuration looks like this:
{code:xml}
<updateRequestProcessingChain name="name" default="true">
  <processor class="solr.CustomUpdateRequestProcessorFactory" >
   <lst name="name">
     <str name="n1">x1</str>
     <str name="n2">x2</str>
   </lst>
  </processor>
  <processor class="solr.RunUpdateProcessorFactory" />
  <processor class="solr.LogUpdateProcessorFactory" />
</updateRequestProcessingChain>
{code}

The big changes are:
 * processor factories are now loaded with NamedListInitalizedPluginLoader -- 
it is no longer custon Node parsing.  
 * the Factories no longer have direct access to core.  if they need it, they 
can implement SorlCoreAware
 * moves all config parsing out of the processor classes.  


  
> Simplify UpdateRequestProcessor API
> -----------------------------------
>
>                 Key: SOLR-660
>                 URL: https://issues.apache.org/jira/browse/SOLR-660
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: SOLR-660-update-processor.patch
>
>
> SOLR-269 introduced UpdateRequestProcessor.  The existing API/configuration 
> is too complicated and should be simplified before release 1.3

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to