[ 
https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618787#action_12618787
 ] 

Yonik Seeley commented on SOLR-622:
-----------------------------------

bq. We should still try to figure out why the searcher obtained in a postCommit 
listener does not get access to the latest searcher.

I think the callback happens before the new searcher is opened.
I think postCommit is also synchronous with the commit process - you don't want 
to rebuild your spell checking index here because it would freeze out any 
updates until it's done.

We have warming mechanism that works for stuff like this... perhaps that is 
what should be used rather than postCommit callbacks?

> SpellCheckComponent should build or load indices on startup and commits
> -----------------------------------------------------------------------
>
>                 Key: SOLR-622
>                 URL: https://issues.apache.org/jira/browse/SOLR-622
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-622.patch, SOLR-622.patch
>
>
> SpellCheckComponent must be able to build/load spell check index on startup 
> and commits. With SOLR-605, SpellCheckComponent can register an event 
> listener for firstSearcher and newSearcher events and rebuild/reload indices 
> as appropriate.
> * If index uses a FSDirectory and exists on disk then just reload it or else 
> build it on firstSearcher event.
> * If index is built from a Solr field then re-build it on newSearcher event.
> This will help avoid having to add QuerySenderListener in configuration and 
> will not force people to issue build on first query.
> All this should be configurable so that people who don't want to rebuild on 
> commits should be able to turn this feature off per configured spell checker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to