Grant,
I think I missed your comment on that thread, sorry about that. Should have
read the new messages before committing this. Reading Eric's comment, he
seemed ok with it.
Three reasons:
1. It does not make any user-facing changes in 1.3 -- no configuration is
touched at all. This was one of the major support issues.
2. We were all in agreement that the current format is a bit ugly. This
issue can make a better config "possible". We should definitely re-think the
configuration post 1.3 but we should not force plugin developers to use an
ugly format for the next 1 year (till spring or whatever comes along) if
something can be done about it so easily.
3. I removed the attribute reading for normal NamedList parsing so that
existing code is not affected at all. A plugin using the <lst
name="defaults"> section cannot use the namedList.get("@name") syntax
anymore. Therefore, old configuration looks and feels like the old one in
the code.
I wasn't sure if a -0 is the same as a -1 but I'll roll this back if I made
a mistake in handling this in the correct fashion.
On Wed, Aug 6, 2008 at 8:51 PM, Grant Ingersoll <[EMAIL PROTECTED]> wrote:
> Shalin,
>
> Why was this committed? There were numerous opinions suggesting otherwise
> that weren't addressed, including most recently on the Solr 1.3 release date
> thread. I think it should be rolled back until there is a consensus amongst
> the committers, which there does not appear to be.
>
>
> -Grant
>
>
> On Aug 6, 2008, at 11:06 AM, Shalin Shekhar Mangar (JIRA) wrote:
>
>
>> [
>> https://issues.apache.org/jira/browse/SOLR-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Shalin Shekhar Mangar resolved SOLR-614.
>> ----------------------------------------
>>
>> Resolution: Fixed
>>
>> Committed revision 683288 after removing the attribute reading for plain
>> NamedList so that existing usage is not changed in any way.
>>
>> Thanks Noble!
>>
>>
>> Allow components to read any kind of XML from solrconfig
>>> --------------------------------------------------------
>>>
>>> Key: SOLR-614
>>> URL: https://issues.apache.org/jira/browse/SOLR-614
>>> Project: Solr
>>> Issue Type: Improvement
>>> Affects Versions: 1.3
>>> Reporter: Noble Paul
>>> Assignee: Shalin Shekhar Mangar
>>> Priority: Trivial
>>> Fix For: 1.3
>>>
>>> Attachments: SOLR-614.patch, SOLR-614.patch, SOLR-614.patch,
>>> SOLR-614.patch
>>>
>>>
>>> All the components initialized by Solr have an init(NamedList args)
>>> initializer. This leads us to writing the configuration needed for the
>>> component in the NamedList xml format. People familiar with Solr may know
>>> the format but most of what is written is noise than information. For users
>>> who are not familiar w/ the format find it too difficult to understand why
>>> they have to write it this way. Moreover , it is not a very efficient way to
>>> configure .
>>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
> --------------------------
> Grant Ingersoll
> http://www.lucidimagination.com
>
> Lucene Helpful Hints:
> http://wiki.apache.org/lucene-java/BasicsOfPerformance
> http://wiki.apache.org/lucene-java/LuceneFAQ
>
>
>
>
>
>
>
>
--
Regards,
Shalin Shekhar Mangar.
