[ 
https://issues.apache.org/jira/browse/SOLR-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620616#action_12620616
 ] 

Yonik Seeley commented on SOLR-545:
-----------------------------------

It seems like this type of reference counting still has a race (either that, or 
it's a form of  optimistic locking that must be re-tried in a loop which is 
currently missing from the code).

Could this be simplified?
SolrCore has a refCount... simply increment it in MultiCore (while in the sync 
block anyway) and decrement it on a SolrCore.release().... the 
SolrCore.Reference class wouldn't be needed.

> remove MultiCore "default" core / cleanup DispatchHandler
> ---------------------------------------------------------
>
>                 Key: SOLR-545
>                 URL: https://issues.apache.org/jira/browse/SOLR-545
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: solr-545.patch, solr-545.patch
>
>
> MultiCore should require a core name in the URL.  If the core name is 
> missing, there should be a 404, not a valid core.  That is:
> http://localhost:8983/solr/select?q=*:*  should return 404.
> While we are at it, we should cleanup the DispatchHandler.  Perhaps the best 
> approach is to treat single core as multicore with only one core?  As is the 
> tangle of potential paths is ugly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to