[jira] Issue Comment Edited: (SOLR-694) error message is misleading when there is no queryconverter defined

[Stefan Oestreicher (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SOLR-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622159#action_12622159
 ] 

dlx edited comment on SOLR-694 at 8/13/08 3:35 AM:
------------------------------------------------------------------

here's a patch

{noformat}
### Eclipse Workspace Patch 1.0
#P solr
Index: src/java/org/apache/solr/handler/component/SpellCheckComponent.java
===================================================================
--- src/java/org/apache/solr/handler/component/SpellCheckComponent.java 
(revision 685498)
+++ src/java/org/apache/solr/handler/component/SpellCheckComponent.java 
(working copy)
@@ -54,6 +54,7 @@
 import org.apache.solr.spelling.IndexBasedSpellChecker;
 import org.apache.solr.spelling.QueryConverter;
 import org.apache.solr.spelling.SolrSpellChecker;
+import org.apache.solr.spelling.SpellingQueryConverter;
 import org.apache.solr.spelling.SpellingResult;
 import org.apache.solr.util.RefCounted;
 import org.apache.solr.util.plugin.NamedListPluginLoader;
@@ -290,6 +291,13 @@
               new NamedListPluginLoader<QueryConverter>("[solrconfig.xml] " + 
xpath, queryConverters);

       loader.load(solrConfig.getResourceLoader(), nodes);
+
+      //ensure that there is at least one query converter defined
+      if (queryConverters.size() == 0) {
+         LOG.warning("no queryConverter defined, using default converter");
+         queryConverters.put("queryConverter", new SpellingQueryConverter());
+      }
+
       //there should only be one
       if (queryConverters.size() == 1) {
         queryConverter = queryConverters.values().iterator().next();
{noformat}

      was (Author: dlx):
    here's a patch

### Eclipse Workspace Patch 1.0
#P solr
Index: src/java/org/apache/solr/handler/component/SpellCheckComponent.java
===================================================================
--- src/java/org/apache/solr/handler/component/SpellCheckComponent.java 
(revision 685498)
+++ src/java/org/apache/solr/handler/component/SpellCheckComponent.java 
(working copy)
@@ -54,6 +54,7 @@
 import org.apache.solr.spelling.IndexBasedSpellChecker;
 import org.apache.solr.spelling.QueryConverter;
 import org.apache.solr.spelling.SolrSpellChecker;
+import org.apache.solr.spelling.SpellingQueryConverter;
 import org.apache.solr.spelling.SpellingResult;
 import org.apache.solr.util.RefCounted;
 import org.apache.solr.util.plugin.NamedListPluginLoader;
@@ -290,6 +291,13 @@
               new NamedListPluginLoader<QueryConverter>("[solrconfig.xml] " + 
xpath, queryConverters);

       loader.load(solrConfig.getResourceLoader(), nodes);
+
+      //ensure that there is at least one query converter defined
+      if (queryConverters.size() == 0) {
+         LOG.warning("no queryConverter defined, using default converter");
+         queryConverters.put("queryConverter", new SpellingQueryConverter());
+      }
+
       //there should only be one
       if (queryConverters.size() == 1) {
         queryConverter = queryConverters.values().iterator().next();

  
> error message is misleading when there is no queryconverter defined
> -------------------------------------------------------------------
>
>                 Key: SOLR-694
>                 URL: https://issues.apache.org/jira/browse/SOLR-694
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Stefan Oestreicher
>            Priority: Trivial
>
> the relevant code (org.apache.solr.handler.component.SpellCheckComponent) 
> only checks if the size of the queryConverters map equals 1 and throws a 
> RuntimeException with the message "One and only one queryConverter may be 
> defined" if it does not.
> But if there are no query converters defined this message is quite misleading.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.