[
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625319#action_12625319
]
Noble Paul commented on SOLR-724:
---------------------------------
bq.Besides, the SolrResourceLoader is available from everywhere.
But , if there is something private in that class it should be fine . right?
bq.My understanding was that till a use-case exists..
Because Solr is also an API there are a lot of requesthandlers which people
write may find some info useful. We can go one step ahead and think "will it
hurt if this is public?" . Moreover , even if something is private I can easily
access the value through reflection. So the kind of security it offers is just
not real
The only advantage I see is that , if you wish to remove something it is easy
if something is not public. So if some feature is experimental it can be kept
not public
Another question to ask before making things public is that can the user can
alter some state in a way that can affect the functionality. If it is purely a
read-only state I guess it should be OK
> CoreDescriptor.{get,set}CoreProperties should probably not be public (but
> package private)
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-724
> URL: https://issues.apache.org/jira/browse/SOLR-724
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Henri Biestro
> Priority: Minor
>
> Exposing them precludes being ever able to fill the CoreDescriptor with
> property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
