[ https://issues.apache.org/jira/browse/SOLR-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630223#action_12630223 ]
David Smiley commented on SOLR-756: ----------------------------------- When anyone says "dismax", there is ambiguity because it might mean one of two things: * SolrPluginUtils.DisjunctionMaxQueryParser which extends Solr's QueryParser which extends Lucene's QueryParser. In this JIRA issue I've offered a patch to this file. This code has to deal with the foundational capability of tapping into Lucene's DisjunctionMaxQuery so that multiple fields can be a default instead of Lucene's just one. I believe this change isn't controversial compared to others, IMO. * The DisMaxQParserPlugin triggered with "qt=dismax" which uses the QueryParser mentioned above and does things like escape user syntax, ,boost various things, min-should-match, etc. Issue SOLR-758 includes my patch to that. I think this plugin is named poorly because dismax is just one thing it does. I suspect your comments might be more applicable to SOLR-758 than they are here. Have you actually seen the source I attached? Are you apposed to the changes I make in this issue? > Make DisjunctionMaxQueryParser generally useful by supporting all query types. > ------------------------------------------------------------------------------ > > Key: SOLR-756 > URL: https://issues.apache.org/jira/browse/SOLR-756 > Project: Solr > Issue Type: Improvement > Affects Versions: 1.3 > Reporter: David Smiley > Attachments: SolrPluginUtilsDisMax.patch > > > This is an enhancement to the DisjunctionMaxQueryParser to work on all the > query variants such as wildcard, prefix, and fuzzy queries, and to support > working in "AND" scenarios that are not processed by the min-should-match > DisMax QParser. This was not in Solr already because DisMax was only used for > a very limited syntax that didn't use those features. In my opinion, this > makes a more suitable base parser for general use because unlike the > Lucene/Solr parser, this one supports multiple default fields whereas other > ones (say Yonik's {!prefix} one for example, can't do dismax). The notion of > a single default field is antiquated and a technical under-the-hood detail of > Lucene that I think Solr should shield the user from by on-the-fly using a > DisMax when multiple fields are used. > (patch to be attached soon) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.