[
https://issues.apache.org/jira/browse/SOLR-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633848#action_12633848
]
Hoss Man commented on SOLR-781:
-------------------------------
Note the comment i made in the thread after Lars opend this issue ... we need
to make sure there's at least one test verifying that <bool
name="facet.sort">true</bool> still works if people are using it as a
default/appends/invariant in their configs.
also: a quick skim a the patch suggests all of the old tests were changed to
use "count" and "lex" ... there should probably still be at least one or two
using "true" and "false" to prove that the back-compat works.
lastly: an enum would probably make sense here rather then a lot of
`sort.equals("count") || sort.equals("true")}` sprinkled throughout the code.
> Change facet.sort from boolean to string and specify sort method explicitely
> ----------------------------------------------------------------------------
>
> Key: SOLR-781
> URL: https://issues.apache.org/jira/browse/SOLR-781
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-781.patch
>
>
> The facet.sort parameter is currently a boolean, which has some downsides as
> explained in http://www.nabble.com/facet.sort-parameter-td19570834.html
> Changing it to a string which explicitely states the sort method would
> address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
