[
https://issues.apache.org/jira/browse/SOLR-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638825#action_12638825
]
Mike Klaas commented on SOLR-793:
---------------------------------
I don't see any issue with the code: adddedDocument is always called within a
synchronized context anyway, after all.
One question: right now you have it set to use the minimum of
autocommit/maxTime and commitWithin on the update command. Might it be better
to always use commitWithin, even if it greater than a specified maxTime? This
would allow the insertion of "less important than normal" docs (right now, it
seems only useful for the "more important" case)
> set a commit time bounds in the <add> command
> ---------------------------------------------
>
> Key: SOLR-793
> URL: https://issues.apache.org/jira/browse/SOLR-793
> Project: Solr
> Issue Type: Improvement
> Components: update
> Reporter: Ryan McKinley
> Priority: Minor
> Attachments: SOLR-793-commitWithin.patch, SOLR-793-commitWithin.patch
>
>
> Currently there are two options for how to handle commiting documents:
> 1. the client explicitly starts the commit via <commit/>
> 2. set an auto commit value on the server -- clients can assume all documents
> will be commited within that time.
> However, this does not help in the case where the clients know what documents
> need updating quickly and others that could wait. I suggest adding:
> {code:xml}
> <add commitWithin="100">...
> {/code:xml}
> to the update syntax so the client can schedule commits explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
