[ 
https://issues.apache.org/jira/browse/SOLR-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639775#action_12639775
 ] 

Shalin Shekhar Mangar commented on SOLR-670:
--------------------------------------------

Thanks for the patch Koji. Updated with a few changes:

# CSVRequestHandler#handleRequestBody should call handleRollback if streams is 
null just like it calls handleCommit
# XmlUpdateRequestHandler#handleRequestBody should call handleRollback if 
streams is null just like it calls handleCommit

Let us think about SolrEventListener changes if users ask for it. Off hand, I 
can't think of a use-case.

I shall commit this shortly.

> UpdateHandler must provide a rollback feature
> ---------------------------------------------
>
>                 Key: SOLR-670
>                 URL: https://issues.apache.org/jira/browse/SOLR-670
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-670.patch, SOLR-670.patch
>
>
> Lucene IndexWriter already has a rollback method. There should be a 
> counterpart for the same in _UpdateHandler_  so that users can do a rollback 
> over http 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to