See https://issues.apache.org/jira/browse/SOLR-852
I've got a start on this. Will post a patch soon.
On Nov 12, 2008, at 2:06 PM, Erik Hatcher wrote:
+1 - keep it DRY!
Erik
On Nov 12, 2008, at 1:19 PM, Grant Ingersoll wrote:
So, I'm working on SOLR-284 (Rich Documents, aka Tika) and I'm
looking at the RichDocumentReqHandler included in that patch and I
notice it has a lot of overlap with CSVRequestHandler and the
XMLUpdateRequestHandler such that there seems to be a fair amount
of commonality for dealing with the ContentStream. Just look at
their handleRequestBody implementations for those classes, they are
almost identical.
Would it make sense to refactor these things into a base class and
then have each implementation override a getLoader() method that
took the base class delegates to?
-Grant
