[
https://issues.apache.org/jira/browse/SOLR-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650035#action_12650035
]
Yonik Seeley commented on SOLR-667:
-----------------------------------
Thanks Noble, looks like that solution should work.
Funny thing with the latest patch though - I get compile errors with "ant test"
from the command line:
{code}
compile-common:
[mkdir] Created dir: f:\code\solr\build\common
[javac] Compiling 39 source files to f:\code\solr\build\common
[javac]
f:\code\solr\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:201:
generic array creation
[javac] CacheEntry[] eset = new CacheEntry[sz];
[javac] ^
[javac]
f:\code\solr\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:379:
non-static class org.apache.solr.common.util.ConcurrentLRUCache.Cache
Entry cannot be referenced from a static context
[javac] return ((CacheEntry)b).lastAccessedCopy <
((CacheEntry)a).lastAccessedCopy;
[...]
{code}
It looks like the compiler thinks that the method is static. IntelliJ doesn't
flag any errors, and I can't see anything wrong after a quick glance at the
code. Does "ant test" from the command line work for you?
> Alternate LRUCache implementation
> ---------------------------------
>
> Key: SOLR-667
> URL: https://issues.apache.org/jira/browse/SOLR-667
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: ConcurrentLRUCache.java, ConcurrentLRUCache.java,
> ConcurrentLRUCache.java, SOLR-667-alternate.patch, SOLR-667-alternate.patch,
> SOLR-667-updates.patch, SOLR-667.patch, SOLR-667.patch, SOLR-667.patch,
> SOLR-667.patch, SOLR-667.patch, SOLR-667.patch, SOLR-667.patch,
> SOLR-667.patch, SOLR-667.patch, SOLR-667.patch, SOLR-667.patch,
> SOLR-667.patch, SOLR-667.patch
>
>
> The only available SolrCache i.e LRUCache is based on _LinkedHashMap_ which
> has _get()_ also synchronized. This can cause severe bottlenecks for faceted
> search. Any alternate implementation which can be faster/better must be
> considered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
