[ 
https://issues.apache.org/jira/browse/SOLR-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651856#action_12651856
 ] 

Ryan McKinley commented on SOLR-889:
------------------------------------

Upgrading httpclient / fileupload and commons-io pass all test unchanged.

Upgrading jetty still has some issues, but I think they may be ok.  

CacheHeaderTest gets an error on testCacheVetoException
{code}
null expected:<[no-cache, ]no-store> but 
was:<[must-revalidate,no-cache,]no-store>

junit.framework.ComparisonFailure: null expected:<[no-cache, ]no-store> but 
was:<[must-revalidate,no-cache,]no-store>
at 
org.apache.solr.servlet.CacheHeaderTest.checkVetoHeaders(CacheHeaderTest.java:65)
at 
org.apache.solr.servlet.CacheHeaderTest.testCacheVetoException(CacheHeaderTest.java:59)
{code}

This looks OK to me -- the header is contains 'no-cache', but it also contains 
'must-revalidate' -- I think we can change the test to make it pass...

> Upgrade dependent libraries to most recent stable version
> ---------------------------------------------------------
>
>                 Key: SOLR-889
>                 URL: https://issues.apache.org/jira/browse/SOLR-889
>             Project: Solr
>          Issue Type: Task
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.4
>
>
> In particular:
>  * commons-httpclient-3.1.jar => httpcore-4.0-beta3.jar
>  * commons-fileupload-1.2.jar => commons-fileupload-1.2.1.jar
>  * commons-io-1.3.1.jar => commons-io-1.4.jar
> perhaps:
>  * jetty-6.1.3.jar => jetty-6.1.14.jar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to