[
https://issues.apache.org/jira/browse/SOLR-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kay Kay updated SOLR-916:
-------------------------
Description:
In CoreContainer.java :: register(name, core, returnPrev) - the documentation
says
it would return a previous core having the same name if it existed *and
returnPrev = true*.
* @return a previous core having the same name if it existed and
returnPrev==true
*/
public SolrCore register(String name, SolrCore core, boolean returnPrev) ..
But as per the code towards the end - the previous core is returned anyway,
irrespective of the value of returnPrev. The difference, though, seems to be
that when returnPrev is false, the previous core (of the same name, if exists)
is closed.
Which one of them is correct . If the code were correct , would the variable be
better renamed as closePrevious , as opposed to returnPrevious.
was:
In CoreContainer.java :: register(name, core, returnPrev) - the documentation
says
*it would return a previous core having the same name if it existed *and
returnPrev = true*.
* @return a previous core having the same name if it existed and
returnPrev==true
*/
public SolrCore register(String name, SolrCore core, boolean returnPrev) ..
But as per the code towards the end - the previous core is returned anyway,
irrespective of the value of returnPrev. The difference, though, seems to be
that when returnPrev is false, the previous core (of the same name, if exists)
is closed.
Which one of them is correct . If the code were correct , would the variable be
better renamed as closePrevious , as opposed to returnPrevious.
> CoreContainer :: register(String, SolrCore, boolean) documentation
> clarification about returnPrev argument
> -----------------------------------------------------------------------------------------------------------
>
> Key: SOLR-916
> URL: https://issues.apache.org/jira/browse/SOLR-916
> Project: Solr
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.3
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.3.1
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In CoreContainer.java :: register(name, core, returnPrev) - the documentation
> says
> it would return a previous core having the same name if it existed *and
> returnPrev = true*.
> * @return a previous core having the same name if it existed and
> returnPrev==true
> */
> public SolrCore register(String name, SolrCore core, boolean returnPrev) ..
> But as per the code towards the end - the previous core is returned anyway,
> irrespective of the value of returnPrev. The difference, though, seems to be
> that when returnPrev is false, the previous core (of the same name, if
> exists) is closed.
> Which one of them is correct . If the code were correct , would the variable
> be better renamed as closePrevious , as opposed to returnPrevious.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
