[
https://issues.apache.org/jira/browse/SOLR-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657421#action_12657421
]
Kay Kay commented on SOLR-924:
------------------------------
Not all of them seems to inherit from Object ( JdbcDataSource inherits from
DataSource<?> ). SolrIndexWriter from IndexWriter etc. So - to ensure proper
cleanup of resources - we need to be having the try .. finally block around
finalizers.
> Solr: Making finalizers call super.finalize() wrapped in try..finally block
> ----------------------------------------------------------------------------
>
> Key: SOLR-924
> URL: https://issues.apache.org/jira/browse/SOLR-924
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler, replication (java)
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-924.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There are some occurences of finalizers in the code base. While the presence
> of them is debatable and discussed in a separate JIRA - the ones that are
> retained are better off wrapped around a try .. finally block to recursively
> call the finalizer of the super class for proper resource usage unwinding ,
> (in case finalizers get invoked ).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
