[ 
https://issues.apache.org/jira/browse/SOLR-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay reopened SOLR-930:
--------------------------


Reopening the issue - since close() is important to keep track of if the 
SolrCore is active ( if we were to re-register the core ,etc.) 

If count > 0 - close() returns silently as of now. 

If count < 0 , close() logs an error ( previously - it used to throwing an 
exception at least , to signify that we are into uncharted territory ). 

With the current behavior - it is impossible to actually know if close() indeed 
completed successfully with counter set to 0, and it will be hard to track 
memory references / reachability of object during memory leaks with the current 
behavior. 

> SolrCore.close() : Warn in the logger when the internal reference count is > 0
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-930
>                 URL: https://issues.apache.org/jira/browse/SOLR-930
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Java 6, Tomcat 6 
>            Reporter: Kay Kay
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-930.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SolrCore.close() -> Add a warning statement when the internal reference count 
> is > 0. ( as opposed to 0, as expected ) - 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to