Remove hardcoded port numbers from TestReplicationHandler
---------------------------------------------------------

                 Key: SOLR-959
                 URL: https://issues.apache.org/jira/browse/SOLR-959
             Project: Solr
          Issue Type: Test
          Components: replication (java)
            Reporter: Hoss Man
            Priority: Minor


TestReplicationHandler has a hardcoded port of 9999 in it for the "master".  
hardcoding port numbers in unit tests is very brittle and error prone and can 
cause problems.  Ideally tests that aren't explicitly testing network related 
functionality should avoid dealing with the network at all, but when neccessary 
it's much better to let the OS pick any available port (as most other solr 
tests do) then to hardcoded it.

in TestReplicationHandler things are a little more complicated because the 
master port number needs to be refered to in the slave config files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to