[
https://issues.apache.org/jira/browse/SOLR-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666058#action_12666058
]
Hoss Man commented on SOLR-914:
-------------------------------
IndexWriter.close() is very cheap *if* the IndexWriter is already closed ... if
it's not already closed, then doing so in the finalize() method is our last
resort. (but I would think a patch to IndexWriter to make it explicitly
implement an "isClosed() method would certainly be nice to help keep the code
clean and make it possible to log a warning).
Ditto for ConcurrentLRUCache ... finalize calls destroy which sets the stop
flag and notifies the thread ... calling destroy() again shouldn't be that
expensive if the client has already called it (which FastLRUCache does) -- but
changing the code to record when destroy() has been called, and log a warning
in finalize if it hasn't been called yet (then calling it) seems like a good
idea.
> Presence of finalize() in the codebase
> ---------------------------------------
>
> Key: SOLR-914
> URL: https://issues.apache.org/jira/browse/SOLR-914
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.4
>
> Original Estimate: 480h
> Remaining Estimate: 480h
>
> There seems to be a number of classes - that implement finalize() method.
> Given that it is perfectly ok for a Java VM to not to call it - may be -
> there has to some other way { try .. finally - when they are created to
> destroy them } to destroy them and the presence of finalize() method , (
> depending on implementation ) might not serve what we want and in some cases
> can end up delaying the gc process, depending on the algorithms.
> $ find . -name *.java | xargs grep finalize
> ./contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/JdbcDataSource.java:
> protected void finalize() {
> ./src/java/org/apache/solr/update/SolrIndexWriter.java: protected void
> finalize() {
> ./src/java/org/apache/solr/core/CoreContainer.java: protected void
> finalize() {
> ./src/java/org/apache/solr/core/SolrCore.java: protected void finalize() {
> ./src/common/org/apache/solr/common/util/ConcurrentLRUCache.java: protected
> void finalize() throws Throwable {
> May be we need to revisit these occurences from a design perspective to see
> if they are necessary / if there is an alternate way of managing guaranteed
> destruction of resources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
