[
https://issues.apache.org/jira/browse/SOLR-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666203#action_12666203
]
Kay Kay commented on SOLR-969:
------------------------------
I agree String-s are portable. But choosing an enum would still be orthogonal
to Strings thanks to the Enum.valueOf(String) method - We can still regenerate
the enum from the String representation (in case of non-Java languages).
In any case - Context seems to be restricted to DIH and seems to be available
since 1.3 only . So making the change now might be more intuitive to the
developer instead of misusing with integers not meant to be passed as an
argument in the first place.
> Context#FULL_DUMP, DELTA_DUMP, FIND_DELTA as an enum
> -----------------------------------------------------
>
> Key: SOLR-969
> URL: https://issues.apache.org/jira/browse/SOLR-969
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-969.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Context # FULL_DUMP, DELTA_DUMP, FIND_DELTA made type-safe as an enum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
