[
https://issues.apache.org/jira/browse/SOLR-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666416#action_12666416
]
Mark Miller commented on SOLR-844:
----------------------------------
I think your missing Otis' point Noble. He is not dismissing this patch on its
technical or useful merits. Hes pointing out that a couple of people have
voiced skepticism and no one has voted for the issue. When thats the case, its
not normal to put the issue in without more discussion. Which is what is
happening, but I don't think your arguments alone should get the code
committed. Rather, after you have expressed your arguments, we wait for votes,
or more input. A couple people seem like they like the idea as well, but that
info has just started coming, so lets let it play out a little before
committing.
My opinion:
My initial thought was negative as well, for the obvious reasons. However, its
such a simple thing (at least for this basic support), improves efficiency a
bit, and could be a lot easier for a solr user to setup than a load balancer
they don't know. I think I am a +1 myself.
On the patch: I havn't spent a lot of time looking at it, but I think its best
practice to only access shared variables within the lock. For instance, you
access isEmpty on a shared variable, then get the lock and access the shared
variable. I realize you want to save the lock cost, but if you need the lock,
you shouldn't do that.
- Mark
> A SolrServer impl to front-end multiple urls
> --------------------------------------------
>
> Key: SOLR-844
> URL: https://issues.apache.org/jira/browse/SOLR-844
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-844.patch, SOLR-844.patch, SOLR-844.patch
>
>
> Currently a {{CommonsHttpSolrServer}} can talk to only one server. This
> demands that the user have a LoadBalancer or do the roundrobin on their own.
> We must have a {{LBHttpSolrServer}} which must automatically do a
> Loadbalancing between multiple hosts. This can be backed by the
> {{CommonsHttpSolrServer}}
> This can have the following other features
> * Automatic failover
> * Optionally take in a file /url containing the the urls of servers so that
> the server list can be automatically updated by periodically loading the
> config
> * Support for adding removing servers during runtime
> * Pluggable Loadbalancing mechanism. (round-robin, weighted round-robin,
> random etc)
> * Pluggable Failover mechanisms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
