[ https://issues.apache.org/jira/browse/SOLR-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672944#action_12672944 ]
Shalin Shekhar Mangar commented on SOLR-921: -------------------------------------------- bq. afterall , we may not need to cache the classes themselves. Loading classes with FQN is as fast as a HashMap lookup after the class is loaded . So we can just cache short-name -> FQN and we are still fine. I think this is a much better approach. No danger of leaking class references. The correct one will always be loaded. Hoss, what do you think about this? > SolrResourceLoader must cache name vs class > ------------------------------------------- > > Key: SOLR-921 > URL: https://issues.apache.org/jira/browse/SOLR-921 > Project: Solr > Issue Type: Improvement > Reporter: Noble Paul > Assignee: Shalin Shekhar Mangar > Fix For: 1.4 > > Attachments: SOLR-921.patch, SOLR-921.patch, SOLR-921.patch > > > every class that is loaded through SolrResourceLoader does a Class.forName() > and when if it is not found a ClassNotFoundExcepton is thrown > Then , it looks up with the various packages and finds the right class if the > name starts with solr. Considering the fact that we usually use this > solr.<classname> format we pay too much of a price for this. After every > lookup the result can be cached in a Map<String,Class> and can be shared > across all the cores and this Map can be stored at the CoreContainer level -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.