[ https://issues.apache.org/jira/browse/SOLR-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681962#action_12681962 ]
Chris Harris commented on SOLR-744: ----------------------------------- Tom, The Lucene half of this patch pair adds unit tests to src/test/org/apache/lucene/analysis/shingle/ShingleFilterTest.java. Do those tests pass when you run them on your custom lucene build, after applying LUCENE-1370? (cd to the top-level of lucene and then run "ant test -Dtestcase=ShingleFilterTest".) I didn't add any tests for the Solr half of the patch pair, but I also don't know how you would test it in a productive manner. > Patch to make ShingleFilter.outputUnigramIfNoNgrams (LUCENE-1370) available > in Solr schema files > ------------------------------------------------------------------------------------------------ > > Key: SOLR-744 > URL: https://issues.apache.org/jira/browse/SOLR-744 > Project: Solr > Issue Type: Improvement > Reporter: Chris Harris > Attachments: SOLR-744.patch > > > See LUCENE-1370 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.