[
https://issues.apache.org/jira/browse/SOLR-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man reopened SOLR-465:
---------------------------
Assignee: Yonik Seeley
Hmmm... yes, this does seem to be an oversight.
the root issue seems to be that there is still a SolrIndexWriter constructor
that takes a IndexDeletionPolicy but does *not* take a DirectoryFactory.
the latest patch seems to be adding yet another constructor (that takes both)
and modifies the callers of the existing IndexDeletionPolicy method to use the
new one ... but since the IndexDeletionPolicy code was added after 1.3 we can
just change it.
It also seems like it might be a good idea to add some logging to
SolrIndexWriter.getDirectory(String,SolrIndexConfig) warning people when legacy
code is being used that might not be respecting their DirectoryFactory.
reopening, assigning to Yonik to review since he & Miller worked on this
originally
> Add configurable DirectoryProvider so that alternate Directory
> implementations can be specified via solrconfig.xml
> ------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-465
> URL: https://issues.apache.org/jira/browse/SOLR-465
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: TJ Laurenzo
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-465-fixes.patch, SOLR-465.patch, SOLR-465.patch,
> SOLR-465.patch, solr-directory-provider.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Solr is presently hard-coded to use the FSDirectory implementation in Lucene.
> Other Directory implementations are possible. This patch creates a new
> DirectoryProvider interface and extends SolrCore to load an implementation of
> it from solrconfig.xml (if specified). If not specified, then it will
> fallback to the FSDirectory.
> A DirectoryProvider plugin can be configured in solrconfig.xml with the
> following XML:
> <directoryProvider class="class.name">
> <!-- Parameters as required by the implementation -->
> </directoryProvider>
> This patch was created against solr trunk checked out on 11/20/2007. Most of
> it is new code and should apply cleanly or with minor relocation. If it does
> not, let me know and I will update.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
