[ 
https://issues.apache.org/jira/browse/SOLR-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698720#action_12698720
 ] 

Shalin Shekhar Mangar commented on SOLR-1099:
---------------------------------------------

{quote}
The only change to the original structure will happen when more parameters will 
be sent, for example, when a query analysis takes place and a "showmatch=true" 
is sent then each matched token will be marked as a "match". I'll have to have 
a closer look at the current response of the AnalysisRequestHandler and see if 
I can support the exact same structure.... my gut feeling is that it's possible.
{quote}

This is the part that I do not understand.

Let me outline what I understood:
# We copy AnalysisRequestHandler (ARH) to DocumentAnalysisRequestHandler and 
deprecate ARH.
# We extract common code (if any) of ARH and FieldARH in to a base class 
AnalysisRequestHandlerBase, as you suggested
# We modify analysis.jsp to use FieldARH (maybe as a separate issue)

You do not need to support AnalysisRequestHandler's format because it will also 
exist by the name of DocumentAnalysisRequestHandler. Since FieldARH is a new 
handler, it does not need to be back-compatible with ARH. Supporting the old 
format is a nice-to-have feature but not necessary.

> FieldAnalysisRequestHandler
> ---------------------------
>
>                 Key: SOLR-1099
>                 URL: https://issues.apache.org/jira/browse/SOLR-1099
>             Project: Solr
>          Issue Type: New Feature
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: FieldAnalysisRequestHandler_incl_test.patch
>
>
> The FieldAnalysisRequestHandler provides the analysis functionality of the 
> web admin page as a service. This handler accepts a filetype/fieldname 
> parameter and a value and as a response returns a breakdown of the analysis 
> process. It is also possible to send a query value which will use the 
> configured query analyzer as well as a showmatch parameter which will then 
> mark every matched token as a match.
> If this handler is added to the code base, I also recommend to rename the 
> current AnalysisRequestHandler to DocumentAnalysisRequestHandler and have 
> them both inherit from one AnalysisRequestHandlerBase class which provides 
> the common functionality of the analysis breakdown and its translation to 
> named lists. This will also enhance the current AnalysisRequestHandler which 
> right now is fairly simplistic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to