[ https://issues.apache.org/jira/browse/SOLR-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700210#action_12700210 ]
Kay Kay commented on SOLR-1106: ------------------------------- {quote} There are places were we may need to override the default implementation. Actually we already do it internally. So if I cannot override the the default commands it may not be as useful {quote} If that were the case - then going by an abstract action and implementations of the same (with option to override default implementations ) would probably be cleaner , allowing default implementations to be overridden. Otherwise we are looking at probably around 6 - 7 methods that could be overridden and as we add more default commands - we might end up adding one more method to be overridden. Let me know what you feel about this. > Pluggable CoreAdminHandler (Action ) architecture that allows for custom > handler access to CoreContainer / request-response > ----------------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-1106 > URL: https://issues.apache.org/jira/browse/SOLR-1106 > Project: Solr > Issue Type: New Feature > Environment: Java 5, Tomcat 6 > Reporter: Kay Kay > Attachments: SOLR-1106.patch, SOLR-1106.patch, SOLR-1106.patch > > Original Estimate: 3h > Remaining Estimate: 3h > > Currently there are certain default actions implemented in CoreAdminHandler ( > CREATE , SWAP, RELOAD , ALIAS etc.) . > For the purpose of in-house monitoring tools that needs to interact with > multiple cores at a given solr instance - we need custom handlers that has > access to CoreContainer and the req, resp of the same. > So - the proposed way of injecting handlers is as follows. > In solr.xml - we add a new schema - > <solr > > <cores adminPath="/cores/admin"> > > <adminActionHandler action="newaction" > handlerType="com.mydomain.myclass" /> > </cores> > </solr> > New abstract class - CoreAdminActionRequestHandler added - that > com.mydomain.myclass would need to inherit from. > Following action handlers registered by default - > registerCustomAdminHandler("create", new > AdminCreateActionRequestHandler()); > registerCustomAdminHandler("rename", new > AdminRenameActionRequestHandler()); > registerCustomAdminHandler("alias", new AdminAliasActionRequestHandler()); > registerCustomAdminHandler("unload", new > AdminUnloadActionRequestHandler()); > registerCustomAdminHandler("status", new > AdminStatusActionRequestHandler()); > registerCustomAdminHandler("persist", new > AdminPersistActionRequestHandler()); > registerCustomAdminHandler("reload", new > AdminReloadActionRequestHandler()); > registerCustomAdminHandler("swap", new AdminSwapActionRequestHandler()); > Trying to register a handler with one that already exists would result in an > error ( Hence - the above mentioned defaults would not be overridden). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.