[
https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704487#action_12704487
]
Shalin Shekhar Mangar commented on SOLR-748:
--------------------------------------------
Wojtek, how about we just make the following changes:
# Inner classes as public static
# The class attributes as public
# Add an experimental API note to each of these classes
I don't prefer keeping top-level classes which are used in one place only. The
getter/setters seem to be just noise. They may give us some flexibility in the
future but in this case that might not be needed?
What do you think?
> FacetComponent helper classes are package restricted
> ----------------------------------------------------
>
> Key: SOLR-748
> URL: https://issues.apache.org/jira/browse/SOLR-748
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Wojtek Piaseczny
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, SOLR-748.patch
>
>
> Original discussion:
> http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html
> The FacetComponent class uses several helper classes that currently have
> package-restricted access. This makes it impossible to extend the
> FacetComponent without rewriting most of its functionality.
> A proposed solution is to make those classes public and make their public
> member variables accessibly only through get and set functions (i.e. make
> them private).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
