[ 
https://issues.apache.org/jira/browse/SOLR-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724584#action_12724584
 ] 

Mark Miller commented on SOLR-1198:
-----------------------------------

Still from the XML if you want. I think he means, by containing everything in 
SolrConfig, you could make a different SolrConfig impl that didnt read from 
XML. Or plug in Spring. Or whatever.

Would be great to get done for 1.4, but I don't think its necessary. I think 
its a great idea though.

> confine all solrconfig.xml parsing to SolrConfig.java
> -----------------------------------------------------
>
>                 Key: SOLR-1198
>                 URL: https://issues.apache.org/jira/browse/SOLR-1198
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1198.patch, SOLR-1198.patch, SOLR-1198.patch, 
> SOLR-1198.patch, SOLR-1198.patch, SOLR-1198.patch, SOLR-1198.patch
>
>
> Currently , xpath evaluations are spread across Solr code. It would be 
> cleaner if if can do it all in one place . All the parsing can be done in 
> SolrConfig.java
> another problem with the current design is that we are not able to benefit 
> from re-use of solrconfig object across cores. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to