[ 
https://issues.apache.org/jira/browse/SOLR-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731966#action_12731966
 ] 

Jay Hill commented on SOLR-1286:
--------------------------------

Looking at the handleRequestBody method of DataImportHandler, it looks like it 
is getting the correct value for "commit" from the request, but during the 
mapping to create the DataImporter.RequestParams object commit is always 
getting set as "true":

SolrParams params = req.getParams();
System.out.println(" -------------------From request : " + 
params.get("commit"));
DataImporter.RequestParams requestParams = new 
DataImporter.RequestParams(getParamsMap(params));
System.out.println(" -------------------RequestParams: " + 
requestParams.commit);

the output:
-------------------From request : false
-------------------RequestParams: true

still digging.


> DIH: The commit parameter is always defaulting to "true" even if "false" is 
> explicitly passed in.
> -------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1286
>                 URL: https://issues.apache.org/jira/browse/SOLR-1286
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>            Reporter: Jay Hill
>            Assignee: Erik Hatcher
>             Fix For: 1.4
>
>         Attachments: SOLR-1286.patch, SOLR-1286.patch, SOLR-1286.patch, 
> SOLR-1286.patch, SOLR-1286.patch
>
>
> I've tried running full and delta imports with commit=false so that the 
> autoCommit will manage all commits to the index. However setting commit=false 
> doesn't have any effect: 
> curl 
> 'http://localhost:8080/solr/dataimporter?command=full-import&commit=false'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to